search

nikfoundas / etcd-viewer

etcd key-value store viewer and editor
Apache License 2.0
183 stars 55 forks source link

Fetch web dependencies from cdn for offline use #10

Closed ferreus closed 7 years ago

ferreus commented 7 years ago

Hi, It's a small change, to pre-fetch all the files from cdn, and use them offline. It would make it possible to use the docker in offline environment.

nikfoundas commented 7 years ago

Hello @ferreus , Thank you very much for your interest in etcd-viewer. I understand that there are isolated environments where http clients (browsers) do not have internet access to retrieve the css and js resources. I understand that your approach is to add the resources to the source tree, but I would prefer to use webjars to include the external resources into the project. Thus avoid having the resources in the source tree and exclude them in gitignore.

Please check the latest commit and verify whether the resources are available offline.

In addition by adding a system property USE_MAXCDN with value "true" (-DUSE_MAXCDN=true) then resources are served through maxcdn.

Kind regards, Nikos

ferreus commented 7 years ago

Thanks for quick response, I have verified the last commit, and the resources are available offline. Thank you very much for the project and this specific fix.

Kind regards, Vladimir

On Fri, Dec 9, 2016 at 4:00 PM, Nikos Fountas notifications@github.com wrote:

Hello @ferreus https://github.com/ferreus , Thank you very much for your interest in etcd-viewer. I understand that there are isolated environments where http clients (browsers) do not have internet access to retrieve the css and js resources. I understand that your approach is to add the resources to the source tree, but I would prefer to use webjars to include the external resources into the project. Thus avoid having the resources in the source tree and exclude them in gitignore.

Please check the latest commit and verify whether the resources are available offline.

In addition by adding a system property USE_MAXCDN with value "true" (-DUSE_MAXCDN=true) then resources are served through maxcdn.

Kind regards, Nikos

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nikfoundas/etcd-viewer/pull/10#issuecomment-266020196, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMmrKAjPIBZeMDS7vSd9qvjiBwbqssJks5rGV7tgaJpZM4LH1uW .

-- If you can't explain it simply, you don't understand it well enough. - Albert Einstein