search

nikgoodley-ibboost / funcito

Automatically exported from code.google.com/p/funcito
0 stars 0 forks source link

Direct call to ASM code in CglibInvokable can have errors in presence of multiple ASM instances #41

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Non-JarJar-ed ASM jar has base packaging of org.objectweb.asm.*, while cglib 
uses JarJar-ed path (net.sf.cglib.asm.* or something like that).  In my 
experience today, there can be a collision between the two.

Proposal is to pass the Method in to the constructor for CglibInvokable 
(besides the MethodProxy), and use it like in JavassistInvokable for 
determining argument count and method name.  Still use MethodProxy for faster 
function execution (maybe test to make sure it's still significantly faster 
enough to make difference, otherwise the two invokables could be collapsed into 
a single class)

Original issue reported on code.google.com by kandpwel...@gmail.com on 4 Jan 2012 at 11:26

GoogleCodeExporter commented 9 years ago

Original comment by kandpwel...@gmail.com on 5 Jan 2012 at 4:37

GoogleCodeExporter commented 9 years ago 
It worked here ohere I was experiencing the problem.  If you don't review this, 
I'll mark it fixed shortly.

Original comment by kandpwel...@gmail.com on 5 Jan 2012 at 6:49

GoogleCodeExporter commented 9 years ago 
closing

Original comment by kandpwel...@gmail.com on 9 Jan 2012 at 3:52