nikgraf / belle

Configurable React Components with great UX
http://nikgraf.github.io/belle/
MIT License
2.51k stars 104 forks source link

Incompatible with React v15.4.0 #330

Closed erikras closed 7 years ago

erikras commented 7 years ago

As of React v15.4.0, you can no longer import from react/lib/* like this library is doing in injectStyles.js. Results in:

Error: Cannot find module 'react/lib/CSSPropertyOperations'
cezarneaga commented 7 years ago

@nikgraf was looking for maintainers a couple of weeks ago. not sure he still has time for belle :) a bit busy this week but will try something this weekend maybe

ig43 commented 7 years ago

Yup - I've just run into exactly the same issue, after having done npm update. I'm using Webpack, so will see if I can set up an alias to point to the correct directory.

nikgraf commented 7 years ago

I will update this over the next couple days … sorry for the delay

ig43 commented 7 years ago

Hi Nik,

Many thanks for getting in touch with an update on status.

From my point of view, I have temporarily worked around it, simply by creating an alias in webpack.config.js. So it’s only a minor issue.

I must say that you have done a fantastic job with Belle. I evaluated several UI libraries, such as MaterialUI etc., but Belle for me was the best and well documented.

So I owe you a big thank you!!

Kind regards,

Ian

Ian Gillingham

Senior Electronic Systems Engineer

Diamond Light Source

DH G.01

Didcot

Oxfordshire

UK

OX11 0DE

Tel: +44 (0)1235 778129

From: Nik Graf [mailto:notifications@github.com] Sent: 01 December 2016 23:26 To: nikgraf/belle Cc: Gillingham, Ian (DLSLtd,RAL,TEC); Comment Subject: Re: [nikgraf/belle] Incompatible with React v15.4.0 (#330)

I will update this over the next couple days … sorry for the delay

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/nikgraf/belle/issues/330#issuecomment-264327273, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIFa8VL-S1KlJeewwgmWkiGfG6kW4WhJks5rD1dqgaJpZM4K2tZM. https://github.com/notifications/beacon/AIFa8ad5PgCaENGMtsML7K0aKaNldKKhks5rD1dqgaJpZM4K2tZM.gif

-- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

nikgraf commented 7 years ago

@erikras @cezarneaga @ig43 just published 3.0.0 https://www.npmjs.com/package/belle which is compatible with React 15.4.0 🙌

Thanks for your patience!

erikras commented 7 years ago

Finally got around to upgrading. ❤️ @nikgraf!!