search

nikgraf / belle

Configurable React Components with great UX
http://nikgraf.github.io/belle/
MIT License
2.51k stars 104 forks source link

use prop-types instead React.PropTypes #339

Closed rohmanhm closed 6 years ago

rohmanhm commented 7 years ago

This morning I've tried to use your lib, but I got warning in my console.

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

React.PropTypes is deprecated as of React v15.5. Please use the prop-types library instead.

Reference: https://facebook.github.io/react/docs/typechecking-with-proptypes.html

nikgraf commented 7 years ago

@rohmanhm good point, interested to create a PR?

elazzabi commented 7 years ago

I'll take this

Edit: Found a strange error, I'm working on it

tconroy commented 7 years ago

@nikgraf: https://github.com/nikgraf/belle/pull/341