search

nikgraf / belle

Configurable React Components with great UX
http://nikgraf.github.io/belle/
MIT License
2.51k stars 104 forks source link

Incompatible with React v16.0.0. #344

Open eddiekollar opened 6 years ago

eddiekollar commented 6 years ago

Similar error message as in #330 : Module not found: Can't resolve 'react-dom/lib/CSSPropertyOperations'

nikgraf commented 6 years ago

Back then we could solved it by moving the import, but at this point functionality must be extracted from the React repo.

@eddiekollar Are you interested to do that? Here is the file: https://github.com/facebook/react/blob/2566b2420b714c00b3a456b8d744a26387eaf511/src/renderers/dom/shared/CSSPropertyOperations.js All the required imports would also be need to be pulled in

eddiekollar commented 6 years ago

@nikgraf Yes, I would be happy to.

nikgraf commented 6 years ago

@eddiekollar awesome, looking forward to your PR :)

btw another alternative would be to switch to styled-components for example. Either way if fine for me. Happy to accept PRs :)

frontmaker commented 6 years ago

@nikgraf I started working on switching to styled-components.Here is my fork https://github.com/frontmaker/belle. Will be glad for any help or advices.

shahabhinandan commented 6 years ago

Guys, is there any update on compatibility of latest React version? Is there a workaround without downgrading React?

testacode commented 5 years ago

fuck