search

nikgraf / react-yjs

React hooks for Yjs
MIT License
60 stars 1 forks source link

Use use-sync-external-store shim so that react-yjs is backwards compatible #7

Closed Laura closed 1 month ago

Laura commented 1 month ago

Uses shim so that the library would work with versions of react before 18 :)

nikgraf commented 1 month ago

hey @Laura, thanks for the PR!

I think since the library is quite new and we never supported older React versions I would not add this kind of support. Better to require React 18 with this one and maybe you could publish a fork to support older versions

Laura commented 1 month ago

Np. Out of curiosity, are you planning on adding more functionality to the library that might require React 18?

nikgraf commented 1 month ago

@Laura not sure - I think the next thing that could/would be valuable is a hook for y-awarness

btw I'm open for suggestions! Any pain points with Yjs you would like to be solved?

Laura commented 1 month ago

I ended up using y-presence for my presence stuff, but presence would be super helpful! :)

nikgraf commented 1 month ago

great, will look into it. closing the PR for now