search

nikhaldi / exception_notification-rake

Sends mail upon failures in Rake tasks
MIT License
39 stars 14 forks source link

Not working with resque-retry #13

Open h0jeZvgoxFepBQ2C opened 9 years ago

h0jeZvgoxFepBQ2C commented 9 years ago

I installed now resque-retry and my exceptions are not sent anymore by mail... I can just see them under the failed tab in the resque-web.. but no exception mails anymore :(

Any suggestions?

Thanks for your great work!

h0jeZvgoxFepBQ2C commented 9 years ago

I found the issue.. It's just related to the MultipleWithRetrySuppression failure backend.. Works fine in the default backend!

See here how to make it work with MultipleWithRetrySuppression failure backend:

Resque::Failure::MultipleWithRetrySuppression.classes = [Resque::Failure::Redis, ExceptionNotification::Resque]
Resque::Failure.backend = Resque::Failure::MultipleWithRetrySuppression

You have to add the ExceptionNotification::Resque failure backend to the MultipleWithRetrySuppression.classes...

I created a pull request, see this commit for more infos: https://github.com/lichtamberg/resque-retry/commit/5624f119dc138d7f69f464f847ce66b8ce9ac018

Would be great if you can add this to your README?

nikhaldi commented 9 years ago

Glad you figured out the issue. This seems actually more related to the exception_notification gem, not to this extension. Maybe submit a pull request for the README in exception_notification?