search

nikhaldi / exception_notification-rake

Sends mail upon failures in Rake tasks
MIT License
39 stars 14 forks source link

No longer maintained? #23

Open TylerRick opened 5 years ago

TylerRick commented 5 years ago

Hi! Is this project still maintained? I see there are PRs from 2016 that are still unresolved.

image

lostapathy commented 5 years ago

@nikhaldi I would be more than happy to help maintain this gem if you would like to offload/share responsibility for it.

nikhaldi commented 5 years ago

Hey! I have not actively maintained this in the last few years because I sadly haven't been using Ruby. So I'm super rusty and out of touch with the ecosystem and don't necessarily trust myself to review PRs.

@lostapathy thanks for stepping up, help would be very appreciated. For the moment, maybe have a quick look at the PRs that @TylerRick submitted and add comments if you have any? I'm happy to merge these tomorrow and put out a release. We can talk about making you an official maintainer as well somehow.

lostapathy commented 5 years ago

22 is mine and just a travis change, it's good to go. I will comment on the other PRs directly.

nikhaldi commented 5 years ago

Thanks a lot @lostapathy! Recent PRs are now merged except for https://github.com/nikhaldi/exception_notification-rake/pull/27 - tbh I have to spend some time on that one to determine if it makes sense. If you have opinions, let us know.

Even without that one I think we are good for a release (especially to get the 4.3 support). Any additional changes that would be good? Otherwise I'll put out a release candidate.

lostapathy commented 5 years ago

I agree with your comment on #27 - rebasing that to master will make it easier to follow.

FWIW I pushed this to production at work based on #25's branch and 4.3 enabled about 10 hours ago. I will update it to point at master on this tree tomorrow morning.

TylerRick commented 1 year ago

27 is still ready to merge