search

nikhaldi / exception_notification-rake

Sends mail upon failures in Rake tasks
MIT License
39 stars 14 forks source link

Works with Rails 6 #28

Closed mtmail closed 4 years ago

mtmail commented 4 years ago

Commit from May (https://github.com/nikhaldi/exception_notification-rake/commit/d0412f4c11d00e55a89dc2636a35feb15b6e56c0) already supports exception_notification 4.4 which changed its dependencies fromactivesupport (>= 4.0, < 6) to activesupport (>= 4.0, < 7).

So master branch already works fine with Rails 6. I tested in my app and got an email after raising an error in a rake task.

Updated the version number since there hasn't been a gem release since January 2017. (https://rubygems.org/gems/exception_notification-rake)

nikhaldi commented 4 years ago

Thanks for the PR and sorry for the late reply. I merged equivalent changes as part of other PRs, so I will close this one. The latest released version 0.3.1 now explicitly supports Rails 6. The code is also being tested against Rails/ActiveSupport 6 on Travis.