search

nikhaldi / exception_notification-rake

Sends mail upon failures in Rake tasks
MIT License
39 stars 14 forks source link

fails when :normalize_subject => true #3

Closed jackdesert closed 11 years ago

jackdesert commented 11 years ago

When the :normalize_subject options is set to true, exception_notification-rake fails with the following error:

NoMethodError: undefined method `normalize_digits' for #ExceptionNotifier::Notifier:0x007f8003f47a88

It's failing on line 125 of lib/exception_notifier/notifier.rb

subject = normalize_digits(subject) if @options[:normalize_subject]

Where :normalize_digits is a method of self.class, not self.

jackdesert commented 11 years ago

Looking at it more closely, it appears that when the rails server encounters an exception, it is ignoring my :normalize_subject => true

option, while when an exception is encountered in a rake task it actually tries to normalize the subject, and fails. So perhaps this is actually a bug with the exception_notification gem.

nikhaldi commented 11 years ago

What versions of exception_notification and exception_notification-rake are you using?

I'll investigate in a bit.

jackdesert commented 11 years ago

exception_notification-rake (0.0.5) exception_notification (3.0.1) Ruby 2.0.0

nikhaldi commented 11 years ago

You're right, this looks like a bug in exception_notification. If you look at the code on the master branch (for the future 4.0.0 version), it appears to be fixed there but it's clearly broken in 3.0.1. I see you filed an issue at https://github.com/smartinez87/exception_notification/issues/158 so I'll close this one.