search

nikhil-sarin / redback

A Bayesian inference software package for end-to-end fitting and interpretation of electromagnetic transients
GNU General Public License v3.0
48 stars 24 forks source link

Lateral spreading revision #243

Closed GPLamb closed 23 hours ago

GPLamb commented 1 week ago

Updated the spreading description in my fork. From pure sound-speed (exponential) to something more ~Granot & Piran 2012 Allows better comparison with hydro results

GPLamb commented 1 week ago

new-lateral_spread Plot with new spreading routine -- top-hat and Gaussian on- and off-axis, with and without lateral spreading

nikhil-sarin commented 1 week ago

Thanks @GPLamb, is this ready to go or are you still working on it? I need to fix a few things on other pull requests before I can merge this in.

GPLamb commented 1 week ago

This should be good to - I've run extra checks against JetSimpy and PyBlastAftefglowMag and it's spot on

nikhil-sarin commented 1 week ago

Nice one

GPLamb commented 1 week ago

new_check__redback_AG_vs_JetSimpy_vs_PyBlastAfterglowMag FYI -- here is the comparison using a top-hat structure and expansion on/off I can't figure out how to, or if, spreading can be turned off in PyBlastAfterglowMag, but it seems to be trying to do both at different times!?

GPLamb commented 23 hours ago

[like] Lamb, Gavin reacted to your message:

From: Nikhil Sarin @.> Sent: Wednesday, November 13, 2024 9:35:30 AM To: nikhil-sarin/redback @.> Cc: Lamb, Gavin @.>; Mention @.> Subject: Re: [nikhil-sarin/redback] Lateral spreading revision (PR #243)

Merged #243https://urldefense.com/v3/__https://github.com/nikhil-sarin/redback/pull/243__;!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydbAMVK9D$ into master.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/nikhil-sarin/redback/pull/243*event-15279562758__;Iw!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydUCMeIM6$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A5QJS4Q5RZI63SNWE46MSVT2AMMOFAVCNFSM6AAAAABRHJSSOGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGI3TSNJWGI3TKOA__;!!IhKztkE!aoLrP1O92FRIqFP9YvyuqQq-KncVoPtyW9OKjWCvBovTPDAoztvT9G3zto-rnGtshSc0bNRH5uZJ2TOAnyRydeU1532P$. You are receiving this because you were mentioned.Message ID: @.***>

Important Notice: Liverpool John Moores University was established as a Higher Education Corporation under section 121 of the Education Reform Act 1988. Further information about Liverpool John Moores University can be found at https://www.ljmu.ac.uk/about-us The information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent and the recipient must ensure that the email (and attachments) are virus free. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University. We will use the personal data information provided by you to respond to your email. For information about how we process personal data and monitor communications please see our Privacy Notice. https://www.ljmu.ac.uk/legal/privacy-and-cookies