search

nikhilaravi / react-native-smart-scroll-view

A smart scroll view component with handling of keyboard events
MIT License
153 stars 31 forks source link

Android Support #11

Closed VansonLeung closed 8 years ago

VansonLeung commented 8 years ago

Lack of android support renders this plugin useless IMHO. Do you mind if I would submit PR for android support sooner or later?

nikhilaravi commented 8 years ago

@VansonLeung yes that would be great, please do submit a PR. Thanks!

VansonLeung commented 8 years ago

[FAIL] After trying I figured the current RN Android scroll view has its own native way to scroll itself upon focus / blur. The worst of all, I can't control it by DeviceEventEmitter because Android build of React Native does not have "keyboardWillShow" or "keyboardWillHide" callbacks. So Fail.

geirman commented 8 years ago

I'm confused. Is this closed because it could not be done? If it couldn't be done (yet!), shouldn't it remain open?

Looking through the code, it appears there's some platform specific logic when setting the event handlers.

So, is Android supported or not? If so, then the readme needs to be updated. It says "A pure JS React Native Component for IOS."