search

nikhilaravi / react-native-smart-scroll-view

A smart scroll view component with handling of keyboard events
MIT License
153 stars 31 forks source link

ScrollContainerStyle proptype number should be object #17

Closed goldenice closed 8 years ago

goldenice commented 8 years ago

That should be an object; scrollContainerStyle property should be able to receive styles, just like the default value is. The default value of scrollContainerStyle is styles.flex1, which is a style, not a number.

I can submit a pull request to fix this if desired?

nikhilaravi commented 8 years ago

@goldenice sorry for the late reply! Yes please do submit a pull request. Thanks! :smile:

nikhilaravi commented 8 years ago

@goldenice did you manage to fix this?

mlabrum commented 8 years ago

@nikhilaravi I've submitted a pull request to fix this :)