search

nikhilaravi / react-native-smart-scroll-view

A smart scroll view component with handling of keyboard events
MIT License
153 stars 31 forks source link

Fix propTypes warning: 'oneOf' is for enums, 'oneOfType' is for types #30

Closed mikelovesrobots closed 8 years ago

mikelovesrobots commented 8 years ago

After adding this package as a dependency, when running our tests we were getting this:

console.error node_modules/react-native/Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js:78 Warning: Invalid argument supplied to oneOf, expected an instance of array.

It was due to PropTypes.oneOf(PropTypes.number, PropTypes.string) which has some problems because oneOf takes an array, and oneOf is just for enums anyway, oneOfType is for types.

No big deal. Anyway, here's the fix.

Thanks for making ReactNativeSmartScrollView!

jrans commented 8 years ago

@mikelovesrobots Thanks for this, sorry for delay in reply. Sadly I'm not working with RN anymore but thank you for keeping this module up to date 😄