search

nikhilbadyal / docker-py-revanced

One Click Python util to build all Revanced apps.
https://nikhilbadyal.github.io/docker-py-revanced/
GNU General Public License v3.0
549 stars 424 forks source link

Not building YouTube #164

Closed a-dn4n closed 1 year ago

a-dn4n commented 1 year ago

Builder fails to produce youtube.apk Screenshot shows the error I'm getting. https://ibb.co/3phKQRj

IMXEren commented 1 year ago

Same here, forked the repo from scratch & still facing errors.

EDIT: Either delete apks/options.toml file (commenting out isn't an option) or comment out src/parser.py L109, L110 to not include options.toml file while patching.

Personal Choice: I did both.

nikhilbadyal commented 1 year ago

Fixed Try again.

IMXEren commented 1 year ago

Thanks, btw as of inotia00/revanced-patches V2.173.2, MicroG patch has been introduced. Mind taking a look at that?

nikhilbadyal commented 1 year ago

Yes, That's what we download and release now.

nikhilbadyal commented 1 year ago

Oh you want to customize mmicrog builds ? If yes, Is there reason for that. Microg is just for login purpose, It's not we interact with that daily.

IMXEren commented 1 year ago

Oh, sorry to mention I was talking about the patches. Can't tell if it works for VancedMicroG but mMicroG works.

IMXEren commented 1 year ago

You're correct but I'd like to address the addition of a patch to you. I think the resources you provide with the repo are already enough. You may choose to not add it. Not a big of a problem.

Spacellary commented 1 year ago

Customizing the Released mMicroG would be cool 😁