Add missing package name for `xiaomi-wearable`

IMXEren commented 3 months ago

PR Type

Bug fix

Description

Added missing package name mapping for xiaomi-wearable in the Patches class.

Changes walkthrough 📝

Relevant files

Bug fix

patches.py

Add missing package name mapping for `xiaomi-wearable`

src/patches.py - Added missing package name mapping for `xiaomi-wearable`.

+1/-0

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Summary by Sourcery

Add missing package name mapping for xiaomi-wearable in the Patches class.

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request adds a missing package name for 'xiaomi-wearable' in the 'src/patches.py' file. The change involves adding a new entry to the dictionary that maps package identifiers to their corresponding names.

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No key issues to review

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Ensure consistency in dictionary value formatting ___ Ensure that the dictionary keys are consistently formatted. The key "com.xiaomi.wearable" uses hyphens in the value "xiaomi-wearable", which is inconsistent with other entries using underscores. Consider changing the value to "xiaomi_wearable" to maintain consistency. [src/patches.py [76]](https://github.com/nikhilbadyal/docker-py-revanced/pull/547/files#diff-d185121a2d06fb05c5e1faa70431dd4ffdff81add38fbd576239bb278010b7a3R76-R76) ```diff -"com.xiaomi.wearable": "xiaomi-wearable", +"com.xiaomi.wearable": "xiaomi_wearable", ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion improves code maintainability by ensuring consistent formatting of dictionary values. This makes the code easier to read and reduces the likelihood of errors.	8

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 6892db89d2efa81554e055365872936259ebd670 | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/6892db89d2efa81554e055365872936259ebd670#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fL199) | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 7fb888a6ae326fad1d20a6a4265c5a6302ad0efa | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/7fb888a6ae326fad1d20a6a4265c5a6302ad0efa#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fR196) | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 6892db89d2efa81554e055365872936259ebd670 | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/6892db89d2efa81554e055365872936259ebd670#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fR196) | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 7fb888a6ae326fad1d20a6a4265c5a6302ad0efa | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/7fb888a6ae326fad1d20a6a4265c5a6302ad0efa#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fL196) | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 6892db89d2efa81554e055365872936259ebd670 | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/6892db89d2efa81554e055365872936259ebd670#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fL198) | | [8555268](https://dashboard.gitguardian.com/workspace/199222/incidents/8555268) | Triggered | Generic Password | 7fb888a6ae326fad1d20a6a4265c5a6302ad0efa | src/parser.py | [View secret](https://github.com/nikhilbadyal/docker-py-revanced/commit/7fb888a6ae326fad1d20a6a4265c5a6302ad0efa#diff-f3801dd467fe03200aeee0231f8d75c571a23d688f3372e6a841565a3c46f69fL196) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}