search

nikhilbchilwant / google-web-toolkit-incubator

Automatically exported from code.google.com/p/google-web-toolkit-incubator
1 stars 1 forks source link

StyleInjector changes prevents build with current gwt release (1.7.0) #306

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What version of gwt and gwt-incubator are you using?
gwt:
com.google.gwt.eclipse.sdkbundle.linux_1.7.0.v200907291526/gwt-linux-1.7.0
gwt-incubator:
trunk

What OS and browser are you using?
linux/firefox 3.0.14
Do you see this error in hosted mode, web mode, or both?
 na
(If possible, please include a test case that shows the problem)

The wiki documentation advises that you build the incubator trunk
with the most recent -release- version of gwt.  A recent change to the
incubator trunk seems to be inconsistent and builds fail against the
current gwt release for the following files related to StyleInjector.  With
build errors like:
[gwt.javac]
/home/bhills/src/incubator/src/com/google/gwt/widgetideas/client/FastTree.java:1
9:
cannot find symbol
[gwt.javac] symbol  : class StyleInjector
[gwt.javac] location: package com.google.gwt.dom.client
[gwt.javac] import com.google.gwt.dom.client.StyleInjector;

bhills@brent-desktop:~/src/incubator$ svn log
com/google/gwt/widgetideas/client/ValueSpinner.java
------------------------------------------------------------------------
r1712 | rjrjr@google.com | 2009-09-09 12:37:00 -0700 (Wed, 09 Sep 2009) | 2
lines

Delete incubator StyleInjector, and use the one in GWT instead

Applies to:
com/google/gwt/widgetideas/client/ValueSpinner.java
com/google/gwt/gen2/widgetbase/client/Gen2CssInjector.java
com/google/gwt/widgetideas/client/CurrencyWidgetWithPreview.java
com/google/gwt/widgetideas/client/FastTree.java:133: cannot find symbol

Hopefully using the test case you have generously provided, what steps will
reproduce the problem? 
1.build trunk against current gwt release fails
2.
3.

What is the expected output? What do you see instead?

Workaround if you have one:

I suspect (but have yet to test) that the build for incubator requires use
of the GWT source instead of the current released version.  If so it should
be documented that way.

Please provide any additional information below,  and thank you for taking
the time and effort to report this issue, as good issue reports are
critical for our quest to make GWT's new widgets and libraries shine.

Original issue reported on code.google.com by hillsbr...@gmail.com on 12 Sep 2009 at 3:52

GoogleCodeExporter commented 9 years ago 
It does build with the current gwt trunk but not the last released version.  
Some of
the documentation on the website led me to have different expectations like:

One of the most important things to remember is that gwt-incubator should be 
compiled
against the most current released version of GWT. You can download the latest 
release
of GWT for your platform here. 

.. and.. 

The gwt-incubator trunk is now compatible only with GWT 1.6 builds or above.

Original comment by hillsbr...@gmail.com on 12 Sep 2009 at 5:01

GoogleCodeExporter commented 9 years ago 
Sorry for the confusion. We're getting very heads down as we try land 2.0 
Milestone
1, and forgot our own policy.

Incubator 1.7 is frozen, and incubator trunk is now tied to GWT trunk. I've 
updated
http://code.google.com/p/google-web-toolkit-incubator/wiki/MakingIncubatorBetter
accordingly.

Original comment by rj...@google.com on 15 Sep 2009 at 4:08

GoogleCodeExporter commented 9 years ago 
@hillsbrent, where does "The gwt-incubator trunk is now compatible only with 
GWT 1.6
builds or above" show up?

Original comment by rj...@google.com on 15 Sep 2009 at 4:09

GoogleCodeExporter commented 9 years ago

Original comment by rj...@google.com on 15 Sep 2009 at 4:09

GoogleCodeExporter commented 9 years ago 
@Ray - Thanks for updating the wiki! "The gwt-incubator trunk is now compatible 
only 
with GWT 1.6 builds or above" is the last line on the project's home page:

http://code.google.com/p/google-web-toolkit-incubator/

Original comment by itruett on 15 Sep 2009 at 10:28

GoogleCodeExporter commented 9 years ago 
And thanks again for the pointer. I've updated the summary. 

Also, more general thanks for all the contributions, and for the civil response 
to
our poor communication here. The community involvement on GWT is really 
inspiring,
and I hope no one is discouraged by the direction we're taking incubator. I 
really
believe that lots of independent incubators is going to be more productive than 
one
monolithic Incubator.

Original comment by rj...@google.com on 16 Sep 2009 at 4:07