search

nikhilg07 / SpringProject

1 stars 0 forks source link

StudentController #4

Open shahmohit9975 opened 2 years ago

shahmohit9975 commented 2 years ago

https://github.com/nikhilg07/SpringProject/blob/928590d39f891e61749ad9cd1efaf97a75aac584/dependencyInjection%202.0/src/main/java/com/quinbay/dependencyInjection/controller/StudentController.java#L15 Private access modifier is not defined.

shahmohit9975 commented 2 years ago

https://github.com/nikhilg07/SpringProject/blob/928590d39f891e61749ad9cd1efaf97a75aac584/dependencyInjection%202.0/src/main/java/com/quinbay/dependencyInjection/controller/StudentController.java#L24

->Student id should be passed as path variable not request param.

shahmohit9975 commented 2 years ago

https://github.com/nikhilg07/SpringProject/blob/928590d39f891e61749ad9cd1efaf97a75aac584/dependencyInjection%202.0/src/main/java/com/quinbay/dependencyInjection/controller/StudentController.java#L46

delete shound be happened by id. not all the field of that entity.

shahmohit9975 commented 2 years ago

https://github.com/nikhilg07/SpringProject/blob/928590d39f891e61749ad9cd1efaf97a75aac584/dependencyInjection%202.0/src/main/java/com/quinbay/dependencyInjection/controller/StudentController.java#L12

add base path