search

nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#525 GLD build number, #2272

Closed nikhilgupta10 closed 8 years ago

nikhilgupta10 commented 8 years ago

When using the command prompt version command, only win32 debug and release are supported:

C: ..\VS2005\x64\Release>gridlabd --version
Revision major: 2
Revision minor: 2
Patch number : 0
Branch name : Four Corners
Build number : WIN32-RELEASE

Looks like this is occurring in cmdarg.c

,

nikhilgupta10 commented 8 years ago

nikhilgupta10 imported these comments from Sourceforge: The user mhauer does not exist anymore. Therefore assigning this to afisher1. "mhauer":The logic uses '#ifdef WIN32', while WIN32 is defined in all 32 and 64 bit Windows builds, leading to ambiguity.

,

"dchassin": * status changed from new to closed

For historical reasons dating back to the implementation 32 bit API during the migration from 16bit of the MSC headers, the use of WIN32 is outside our control and the WIN32 macro must remain as defined. It should be defined for all windows builds, regardless of whether it's a 32bit or 64bit platform. At this time there is no need for a macro to identify specifically when running under Windows 64-bit because there is no 64-bit API.

,

"dchassin": * cc jcfuller added

It is probably a good idea to change the version reporting to a single line that conforms more to the standard for automake.

PACKAGE MAJOR.MINOR.PATCH.REVNUM BRANCH

In this case, special builds would be labeled with an \M\ after the REVNUM.

For example: 

  host% gridlabd --version
  GridLAB-D 3.0.0.2610M Grizzly
  host%

Would this be acceptable?

,

"dchassin":This is resolved by ticket:660.

,

"dchassin": * status changed from reopened to closed