search

nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#556 ETP solver appears to have erroneous code, #2301

Closed nikhilgupta10 closed 8 years ago

nikhilgupta10 commented 8 years ago

The code around line 80 is clearly erroneous and does nothing. 

  if (t!=0) // initial t changed to inflexion point
    double f = EVAL(t,a,n,b,m,c);

We need to determine why it was deemed necessary, why it doesn't make difference that it does nothing, and what should be done about it.

,

nikhilgupta10 commented 8 years ago

nikhilgupta10 imported these comments from Sourceforge: The user mhauer does not exist anymore. Therefore assigning this to afisher1. "dchassin": * priority changed from undetermined to major

Was fixed in 2.3, and seems to work okay.

,

"jcfuller":Has anyone reported any errors associated with this change?? Can we close this ticket?

,

"jcfuller": * status changed from new to closed