nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#690 Collected minor fixes from Ausgrid, #2430

Closed nikhilgupta10 closed 7 years ago

nikhilgupta10 commented 7 years ago

The following ticket is a placeholder for a collection of fixes for small defects that have been found and fixed by the Ausgrid project team.

A branch will be created for this ticket and will have all the fixes checked in a separate changesets.

Further details on each of the fixes will be added shortly.

Only fixes that are small and considered uncontroversial will be added to this ticket. Other items that are more experimental in nature will have separate tickets created.

,

nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: The user dchassin does not exist anymore. Therefore assigning this to afisher1. "neilstephens":https://sourceforge.net/apps/trac/gridlab-d/changeset/3813

In the gridlabd.h used to compile runtime classes, there was a missing function pointer in the callback struct. This caused callbacks after that point in the struct to jump to the wrong function in the core.

Added the function pointer in the above changeset, and runtime callbacks now work fine.

,

"neilstephens":https://sourceforge.net/apps/trac/gridlab-d/changeset/3814

DST handling in timestamp.c wasn't handling southern hemisphere timezones properly. Daylight savings spans the end of one calendar year and the start of the next in the southern hemisphere, so the end of DST is before the start of DST for any given year.

Added logic to check for southern hemisphere in timestamp.c, and added Australian Eastern Time to tzinfo.txt in the above changeset.

,

"dchassin": * owner changed from dchassin to jcfuller

I believe this should be Andy's to merge into trunk. I'm fine with what they've done.

,

"jcfuller":- Description has changed:

Diff: