nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#720 Taxonomy feeder models all have bad timezone spec, #2458

Closed nikhilgupta10 closed 7 years ago

nikhilgupta10 commented 7 years ago

The taxonomy feeder models have the timezone set to EST+8EDT, which is not valid. Recommend review of all GLM files to detect other instances of this error.

This raises the question of whether a bad timezone spec should be a fatal error.

,

nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: The user h6294443 does not exist anymore. Therefore assigning this to afisher1. "jcfuller": * priority changed from major to critical ,

"jcfuller":- Description has changed:

Diff:

object clock { timezone EST+5EDT; starttime 01-01-2001 00:00:00; }

and not:

object clock {
starttime 01-01-2001 00:00:00; timezone EST+8EDT; }

Common errors:

1) The clock object is order dependent, so timezone before starttime is different than after. Should be the first case. 2) Bad timezone designations, e.g., 8 EDT does not exist (only 5 EDT or 8 PST).,

"jcfuller":- Milestone: Version 3.0 RC 1 --> Version 3.1 Stable ,

"h6294443":- status: new --> closed ,

"h6294443":Modified all taxonomy feeders and three models in \models to correct time zones and correct order of time zone and start time declaration.,