#804 climate and csv reader,

[nikhilgupta10]

When eader XXX.csv\ is not specified in \object climate\, a silent unhandled exception occurs. For example:

object climate {

name my_climate;
tmyfile weather.csv;
//reader my_csv;

}

object csv_reader {

name my_csv;
filename weather.csv;

}

This needs to be caught with an error message.

,

[nikhilgupta10]

nikhilgupta10 imported these comments from Sourceforge: "mhauer":This used to work okay -- it was supposed to detect that there was no reader* in the class, it would create a 'header-less' instance of the csv_reader class and go about its merry way.

,

"jcfuller":- Description has changed:

Diff:

• status: new --> assigned
• Resolution: --> none

• Component: Climate --> climate ,

  "andyfisher":What exactly should be the fix for this? if the property eader\ is NULL and myfile\ contains .csv throw error?,

  "dchassin":I don't see how the exception is not being caught. Either no exception is thrown, or the exception is not using the standard types. Can we verify that an exception is actually being thrown?,

  "jcfuller":Dave - there currently is NOT an exception, so it tries to map to non-existent locations. It fails out completely silent.

Andy - the fix should be to check if the user is trying to specify a certain format. For example:

• if (in climate) the csv reader variable points to an object, make sure the object exists

• if it does not point to a csv reader (implying a tmy file), check the file to make sure the tmy format makes sense -- easiest check is make sure the header line makes sense or do a check sum on the length of the second line in the file.,

  "dchassin":Ok, please clarify. The original post says  silent unhandled exception occurs\ (meaning there is hrow\ without a matching \catch\, which is very bad). That may not be what was intended based on this last post. Are we talking about an unhandled exception being thrown or an error which is not being detected and should be a thrown exception? ,

  "andyfisher":I believe what Jason is saying is that there is no hrow\ being implemented. (i.e.) we set reader to my_csv but there is no object called my_csv and we go trying to read certain properties from null pointer and an system level exception occurs from trying to read that null pointer. We also assume that the file given in tmyfile is in tmy2 format if reader is not set. This is something that I can fix.,

  "dchassin":Ok. That makes sense.,

  "andyfisher":Fixed and validated in revision 4804 of 3.1 ,

  "andyfisher":- status: assigned --> closed

• Resolution: none --> fixed ,