nikhilgupta10
commented
7 years ago nikhilgupta10 imported these comments from Sourceforge: The user dchassin does not exist anymore. Therefore assigning this to afisher1. "jcfuller":What is this fix? We still have an open ticket on unit errors (545, 646, 751, and 795).
Why are we using asterisks to replace periods? Are you also using ()\ to differentiate proper mathematical formulation.
I'd really like to see a spec on this before we implement it completely.,
"dchassin":People (myself included) have been specifying units incorrectly and a bug in core failed to detect it. Periods have never been supported and neither have parenthesis. The units are always numerator / denominator with stars separating units in each. Undetected Misuse of units is what has been causing units to show up wrong and cause unit conversion problems.
The spec for units has not changed and I don't propose we change it. We've just been using them wrong. I looked at whether periods could supported and I think we can't change the parser because it would be ambiguous with real number parsing.
D.
On Jul 25, 2014, at 8:32 AM, \Jason Fuller\ jcfuller@users.sf.net wrote:
What is this fix? We still have an open ticket on unit errors (545, 646, 751, and 795).
Why are we using asterisks to replace periods? Are you also using ()\ to differentiate proper mathematical formulation.
I'd really like to see a spec on this before we implement it completely.
\ [tickets:#861] Unit fix not completed correctly**
Status: new Milestone: Unscheduled Created: Fri Jul 25, 2014 02:39 PM UTC by David P. Chassin Last Updated: Fri Jul 25, 2014 02:39 PM UTC Owner: nobody
Only some of the units that use periods instead of asterisks were fixed. For example, waterheater and refrigerator still use periods. They were fixed in the ticket along with all the others but that doesn't not appear to have stuck when copied to trunk.
Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/gridlab-d/tickets/861/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/,
"jcfuller":Got it. I think it stemmed from the original house_a model - everyone just copied what was in there!!
I looked at the documentation and its definitely not clear. Let's go ahead and fix this, then flag it as a documentation issue to be resolved once we have the common documentation wiki back online.,
"dchassin":I can fix the docs. It's a pretty insidious combination of bugs, bad habits, and weak docs. ,
"dchassin":There may also be a validation problem because this partial fix wasn't detected in trunk yet trunk loads of residential module fail as of this morning. ,
"jcfuller":- assigned_to: David P. Chassin
-
Milestone: Unscheduled --> Version 3.1 RC1 ,
"jcfuller":It seems this might be resolved now. Do we need to merge to v3.1, or was this only in trunk?,
"dchassin":I only fixed trunk. Don't know if anyone merged this to 3.1.,
"jcfuller":- assigned_to: David P. Chassin --> Laurentiu Marinovici
-
Resolution: none --> validate ,
"dchassin":Fixed in 3.1 in r4787. Validation on Mac done. Linux and PC still not validated.,
"laurmarinovici":I did the validation. Discovered the 'period' sign in pqload.cpp and frequency_gen.cpp, but as I was doing the validation, they have been fixed and committed by Andy, so those changes have been tested as well. Shall we close this ticket (#861)?,
"dchassin":Keep in mind there is the larger problem that these unit errors did not cause the simulation to exit. Unless that is entered in another ticket, this one should stay open to address that bug.,
"laurmarinovici":- status: new --> accepted
- Milestone: Version 3.1 RC1 --> Version 3.2 RC1
-
Resolution: validate --> none ,
"laurmarinovici":Keeping this ticket open for the larger problem that these unit errors did not cause the simulation to exit, but only threw out a message.,
"laurmarinovici":- status: accepted --> assigned
-
assigned_to: Laurentiu Marinovici --> David P. Chassin ,
"dchassin":- assigned_to: David P. Chassin --> Laurentiu Marinovici
-
Resolution: none --> validate ,
"dchassin":Fixed in trunk. Serious enough change to warrant full validation in trunk before copying to 3.1. Validated on mac ok.,
"dchassin":- Owner: Laurentiu Marinovici --> David P. Chassin
-
Milestone: Version 3.2 RC1 --> Unscheduled ,
"dchassin":- status: assigned --> closed
- Milestone: Unscheduled --> Knothole Interim
-
Resolution: validate --> fixed ,
"dchassin":This appears to have been fixed properly in trunk.,
Only some of the units that use periods instead of asterisks were fixed. For example, waterheater and refrigerator still use periods. They were fixed in the ticket along with all the others but that doesn't not appear to have stuck when copied to trunk.,