nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#916 voltdump crashes core when runtime classes are defined, #2642

Open nikhilgupta10 opened 7 years ago

nikhilgupta10 commented 7 years ago

There is a missing set of tests in find.c for object searches that use module names, which are non-exitent for runtime classes. As a result, the find_object functions fail catastrophically on bad pointers. We need to add the following to find.c:

line 156: add !=NULL && b!=NULL &&\ before \strcmp\;
line 255: add \obj->oclass->module!=NULL &&\ before \compare_string\r
~~~~~,
nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: "dchassin":- summary: voltdump fails when runtime classes are used --> voltdump crashes core when runtime classes are defined

Diff:


--- old
+++ new
@@ -1,4 +1,4 @@
-There is a missing set of tests in find.c for object searches that use module names, which are non-exitent for runtime classes.  As a result, the find_object functions fails catastrophically on bad pointers.  We need to add the following to find.c:
+There is a missing set of tests in find.c for object searches that use module names, which are non-exitent for runtime classes.  As a result, the find_object functions fail catastrophically on bad pointers.  We need to add the following to find.c:

line 156: add !=NULL && b!=NULL &&\ before \strcmp\;


,

 "dchassin":Fixed in 3.1 at r4982. Note that unless a 3.1 patch is released, this fix will not come out until 3.2.  Please contact the project team if you need the fix patched in the download version before 3.2 is release.,

 "dchassin":Fixed in trunk at r4983.,

 "dchassin":- **Resolution**: none --> fixed
,

 "dchassin":Fixed apply to 3.2 in r5208.,

 "dchassin":- **Milestone**: Unscheduled --> Version 4.0 RC1
,

 "dchassin":- **Status**: new --> unassigned
,