nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#919 repeat message formatting over zealous with new C++ API messages, #2645

Open nikhilgupta10 opened 7 years ago

nikhilgupta10 commented 7 years ago

The repeat message test using the format string to determine whether the message is essentially the same (i.e., only the values differ). This is nice to avoid a flood of warnings, but doesn't work with the new C++ API because it uses an intermediate buffer which confuses the warning output handler.

Our options are as follows:

1) Look at the content of the message itself and decide suppression based on that. Not great because it doesn't support the basic functionality we have now, i.e., suppressing essentially similar messages.

2) Look at the first few characters of the message. Better but not surefire. I like this option better because it will usually retain the existing functionality and won't be confused by the new C++ API calls.

This doesn't show up often (yet), but it will become more frequent as we stop using gl_warning() in favor of gld_object::warning() in modules that support the new C++ API.,

nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: The user dchassin does not exist anymore. Therefore assigning this to afisher1. "dchassin":- Milestone: Unscheduled --> Version 4.0 RC1 ,

"dchassin":- Status: new --> unassigned ,