nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#953 Incorrect use of enumeration, #2679

Closed nikhilgupta10 closed 7 years ago

nikhilgupta10 commented 7 years ago

I/u2019ve discovered today in GridLAB-D while trying to send override signal to water heaters.

When I sent a numerical value of /u201c-1/u201d, an error was reported saying it doesn/u2019t understand the value. So I switched to sending actual state strings, that is ON, OFF, NORMAL. That worked, but when I looked in the OVERRIDE property recorder, I saw this:

timestamp H1_waterheater H2_waterheater H3_waterheater H4_waterheater H5_waterheater 2010-08-16 00:00:00 UTC NORMAL NORMAL NORMAL NORMAL NORMAL 2010-08-16 00:00:30 UTC NORMAL NORMAL NORMAL NORMAL NORMAL 2010-08-16 00:01:00 UTC NORMAL NORMAL NORMAL NORMAL NORMAL 2010-08-16 00:01:30 UTC NORMAL NORMAL NORMAL NORMAL NORMAL 2010-08-16 00:02:00 UTC NORMAL NORMAL NORMAL NORMAL NORMAL 2010-08-16 00:02:30 UTC ON -1 NORMAL NORMAL ON 2010-08-16 00:03:00 UTC ON -1 NORMAL NORMAL ON 2010-08-16 00:03:30 UTC ON ON -1 ON -1 2010-08-16 00:04:00 UTC ON ON -1 ON -1 2010-08-16 00:04:30 UTC NORMAL -1 NORMAL ON NORMAL 2010-08-16 00:05:00 UTC NORMAL -1 NORMAL ON NORMAL 2010-08-16 00:05:30 UTC ON ON ON ON -1 2010-08-16 00:06:00 UTC ON ON ON ON -1

This time it looks as if OFF is switched to -1, and kept like that, even though -1 did not seem to be recognized and translated into OFF. ,

nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: "dchassin":- status: new --> accepted ,

"dchassin":Branched ticket/953 from trunk at r5405,

"dchassin":Proposed fix posted to r5406 but it causes market/autotest/test_dutycycle_CPP.glm to fail.,

"dchassin":- Milestone: Unscheduled --> Knothole Interim ,

"dchassin":- status: accepted --> assigned ,

"dchassin":- assigned_to: David P. Chassin --> Andy Fisher ,

"andyfisher":- status: assigned --> closed ,

"andyfisher":found the issue with the failing autotest. needed to update passive_controller with the correct values for re_override. Merged into trunk at r5532. Closing ticket.,