#961 TMY3 doesn't parse all available fields that correspond to TMY2,

nikhilgupta10 imported these comments from Sourceforge: "t-hardy":Adding new item to ticket as per Nikil's request:

Temperature as read from TMY3 files does not appear to be parsed/converted correctly. Using Seattle TMY3 on August 6 the TMY3 file shows these dry bulb values (in 'C): 12.2 11.6 11.4 11 11.9 12 14.2 15.3 17.1 17.9 19.5 21.7 22.6 23.7 23.8 23.4 23.8 21.8 19.6 19.9 17.9 17.7 16.9

The values (in 'F) read by the climate object when GLD is run are:

34.162 34.162 33.982 33.982 33.982 33.982 34.162 34.522 34.702 35.062 35.062 35.422 35.782 35.962 36.142 36.142 36.142 36.142 35.782 35.422 35.422 35.062 35.062 34.882,

"t-hardy":Adding item from ticket 960 to this ticket to simplify trouble-shooting per Nikhil's request.

Error message regarding the number of fields TMY3 reader should be parsing assumes it is the number of fields as TMY2. Error message is: \TMY reader did not get 17 values for line time.... 17 values is appropriate for TMY2 but not TMY3; TMY3 needs its own error message.,

"t-hardy":Looking at a TMY3 file, it appears that the resolution is to 0.1/u2019C but the actual values are in /u2018C directly. For example, the Spokane TMY3 file range from -16.7 to 36.1, reasonable values. With the TMY2 values being in tenths (100 = 10.0 'C), I bet the TMY3 value is being divided by 10 before the unit coversion takes place. This would explain why all the values are only a few degrees above 32 'F.,

"dchassin":I took a quick look at the code in branch/3.2 and not only does it not read the file completely, but it needs to be implemented differently. The TMY3 reader is embedded in the TMY2 reader code when it really should be a separate reader implementation because the units and data are different. This code should not be copied to trunk in its current form because it will lead to erroneous results and confusing diagnostic messages. ,

"t-hardy":Added TMY2 and TMY3 autotest on cloud model to this ticket to validate the TMY3 reader. (TMY2 autotest is same as one added to ticket 924 recently). ,

"nikhilgupta10":- status: new --> assigned

assigned_to: Sri Nikhil Gupta Gourisetti --> tdhardy ,

"t-hardy":Updated TMY3 autotest player file to match model output and committed change. R5519 contains fixed player file.,

"t-hardy":- Resolution: none --> fixed ,

"t-hardy":R5519 contains fixed player file for TMY3 cloud autotest.,

"t-hardy":R5541 contains an extra line of code in climate.cpp that warns our cloud model may require patience and/or computational resources. Validated that the appropriate autotest gridlabd.wrn contains the message.,

"t-hardy":- status: assigned --> closed ,

nikhilgupta10 / GridLAB-D

#961 TMY3 doesn't parse all available fields that correspond to TMY2, #2687