nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#986 The --output option does not work as shown in course material, #2711

Open nikhilgupta10 opened 7 years ago

nikhilgupta10 commented 7 years ago

The --output option fails on the .glm extension, and when .txt or .gld are used it creates files that cannot be loaded. The file format used is the Version 1 GLM format and many newer features result in GLM syntax that is not valid. The saveall() function needs to put #ifdefs around anything that isn't fully supported by the loader.,

nikhilgupta10 commented 7 years ago

nikhilgupta10 imported these comments from Sourceforge: The user dchassin does not exist anymore. Therefore assigning this to afisher1. "dchassin":- Description has changed:

Diff:


--- old
+++ new
@@ -1 +1 @@
-The --output option fails on the .glm extension, and when .txt or .gld are used it creates files that cannot be loaded.  The file format used is the Version 1 GLM format and many newer features result in GLM syntax that is not valid.  The saveall() function needs to put #ifdefs around anything that isn't fully supported by the loader.
+The `--output` option fails on the `.glm` extension, and when `.txt` or `.gld` are used it creates files that cannot be loaded.  The file format used is the Version 1 GLM format and many newer features result in GLM syntax that is not valid.  The `saveall()` function needs to put `#ifdef`s around anything that isn't fully supported by the loader.

,

"dchassin":Note also that the output routines do not output all model elements. In particular, filter, schedules, user-defined globals, and runtime code is not stored in the output file.,

"dchassin":One highly desirable feature in the GLM output to provide #ifdef INCLUDE_XYZ / #endif around each non-essential output block, e.g., class definitions, non-default globals.,

"dchassin":There should be validation tests for GLM output, i.e., load a model with asserts, output the model and then run a separate test that inputs the model with the simple GLM code

#include \output_model.glm\r
~~~,