nikhilgupta10 / GridLAB-D

Other
1 stars 0 forks source link

#44 Reenable phase connectivity check in powerflow link init, #770

Closed nikhilgupta10 closed 8 years ago

nikhilgupta10 commented 8 years ago

Both from and to nodes must be initialized before this check will work properly. This is more properly done by a check() function (see network module for an example).

03/21/08 14:16:10 changed by mhauer /u00c2/u015b
On hold while the powerflow module gets torn apart and rebuild.

,

nikhilgupta10 commented 8 years ago

nikhilgupta10 imported these comments from Sourceforge:

Aren't phases inherited when not set? So the only thing that needs to be done is verify that a link has the same phases that are included from and to nodes, but there is not requirement that the all the phases of link match all the phases of the node.

Also, when node-node is used, the parent node must have all the phases used by the child node but the child node can omit some (or all) of the phases of the parent node.

,

Fixed as part of changeset:201. Link now checks both ends to make sure phases of nodes are at minimum what it carries. As part of this general idea, also implemented check to make sure phases a parent object at minimum meet the phase requirements of a childed object for parent-child relationships.

,