Use downstream-patched GTK3

nikhiljha / pp-fedora-sdsetup

PinePhone Fedora Image Generation Script

GNU General Public License v3.0

106 stars 21 forks source link

Use downstream-patched GTK3 #18

Open thibaultamartin opened 4 years ago

thibaultamartin commented 4 years ago

Hi,

Purism patched GTK3 downstream for it to work on mobile. Not using it causes all sorts of issues, especially with dialogs etc. Using the patched version will improve the overall experience.

See Purism's Librem5/gtk repository

thibaultamartin commented 4 years ago

Useful links:

When I'm planning to do:

[ ] Clone and build vanilla GTK (to get familiar with the build process & dependencies)
[ ] Clone and build Purism's downstream patched gtk
[ ] Create a rpm of Purism's downstream patched gtk
[ ] Upload the rpm to a COPR repository
[ ] Set the COPR repository with a higher priority on my system and test
[ ] Create a MR to update the Fedora Mobile image

Torbuntu commented 4 years ago

Just something to note: The patched gtk will only affect applications which use the patched version. Such as calls, chatty and squeekboard. Other software not packaged from the purism sources such as gnome related packages will not see a difference until the changes are either patched or upstream.

thibaultamartin commented 4 years ago

This is not exactly true :)

This will affect all the applications using this GTK version (i.e. 3.24.20). This means most GTK applications using rpm packages. Flatpak apps on the opposite will not be impacted, since they use the GTK version shipped with their runtime.

Torbuntu commented 4 years ago

I think I misunderstood what the downstream patches are for then.

Kekun commented 4 years ago

They tweak GTK to make it work better on phones, at the price of working less well on desktop (it doesn't make GTK adaptive). We ship them on PureOS for the Librem 5 (not laptops) since ages, I'm not proud of them but they do the job.

frzifus commented 4 years ago

shouldn't the goal be to bring the patches into the main branch instead of maintaining an extra branch with an older version?

thibaultamartin commented 4 years ago

GTK has release cycles, which means you can't release a new version with what you're adding whenever you want.

The changes Purism made would need a new major release (i.e. releasing GTK4). When @Kekun started working on making GTK adaptive, GTK4 wasn't to be released anytime soon and GTK3 was "frozen" (i.e. it was not possible to introduce major changes).

This situation lead to patching GTK3 downstream, so people can start playing around with their phone. Now Adrien and members of the community are working on porting all the relevant work to GTK4. This takes a lot of work (and time). If there was a way to fund Adrien and other people working on that, I'd send them money right away

nikhiljha commented 4 years ago

patched gtk was in the COPR until today, but it's kinda buggy so I removed it

feel free to build it yourself and try it out -> https://gitlab.com/fedora-mobile/misc/-/blob/master/gtk.spec

ahussey-redhat commented 2 years ago

GTK4 was released at the end of 2020. Noting it is now 2022, is this issue resolved?