nikhilk / node-tensorflow

Node.js + TensorFlow
Apache License 2.0
587 stars 59 forks source link

problems expanding .tar.gz #20

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 6 years ago
/home/lms/.node-gyp/8.9.3/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’            
   declarator __attribute__((deprecated(message)))                                                               
   ^~~~~~~~~~                                                                                                    
  SOLINK_MODULE(target) Release/obj.target/ffi_bindings.node                                                     
  COPY Release/ffi_bindings.node                                                                                 
make: Leaving directory '/home/lms/src/node-tensorflow/node_modules/ffi/build'                                   

> tensorflow@0.6.4 postinstall /home/lms/src/node-tensorflow                                                     
> npm run -s installtf                                                                                           

Downloading ...                                                                                                  
https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.4.1.tar.gz              
  --> /home/lms/src/node-tensorflow/tensorflow.tar.gz ...                                                        
Expanding and installing ...                                                                                     

gzip: stdin: unexpected end of file                                                                              
tar: Unexpected EOF in archive                                                                                   
tar: Unexpected EOF in archive                                                                                   
tar: Error is not recoverable: exiting now                                                                       
Unable to setup TensorFlow libraries.                                                                            
npm ERR! code ELIFECYCLE                                                                                         
npm ERR! errno 1                                                                                                 
npm ERR! tensorflow@0.6.4 postinstall: `npm run -s installtf`                                                    
npm ERR! Exit status 1                                                                                           
npm ERR!                                                                                                         
npm ERR! Failed at the tensorflow@0.6.4 postinstall script.                                                      
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.               

npm ERR! A complete log of this run can be found in:                                                             
npm ERR!     /home/lms/.npm/_logs/2018-01-05T20_19_59_773Z-debug.log                                             

It happens randomly so I'm guessing it's some sort of race condition.

nikhilk commented 6 years ago

Fixed when I merged your pull request with f71d2cf14d82757c35b0102087024de7329faac5 ... will close when a new package is published to npm.

nikhilk commented 6 years ago

Incorporated into 0.6.5 which has been published.

ralphtheninja commented 6 years ago

@nikhilk A tip is to use e.g. npm version patch when creating a new version. It will

It's really useful when you just want to make a release and it also makes it very clear when you look at the git history to see where a version was created. Especially with matching git tags. Just my 2 cents. You do whatever you want to do obviously :)

nikhilk commented 6 years ago

OK, I'll need to look into it, since I agree its useful to create a git tag for each release.

As I read your comment, the one part that raises questions regarding how it would fit my workflow is that I'd like a step in the middle of 1st and 2nd -- which is to validate my new package with new version works before committing it.

ralphtheninja commented 6 years ago

which is to validate my new package with new version works before committing it

What does validate mean to you in this case?