search

nikhilkarve / leetcode-tracker

Building a interview problem tracker for personal use with React. Under development 🚧
3 stars 1 forks source link

New feature ideas are welcome #1

Open nikhilkarve opened 1 year ago

nikhilkarve commented 1 year ago

If you think of any new feature, feel free to suggest.

JuanGuerrero09 commented 1 year ago

hi, I would suggest create (or add with a library) a modal to addProblem, and create some required fields, so you can't send and empty problem. Also, I was reading the code, and you can use conditional rendering instead of the if/else. I found this template of notion and I think that the features that it have could be great to add, instead of 10 days / 30 days / 2 months (that I really don't know what those checkbox mean) image

JuanGuerrero09 commented 1 year ago

I've found your project here tho image I'm really new in this collaborative aspect, but if you are okay with it, I can help here

nikhilkarve commented 1 year ago

Hi Juan, welcome!

Hmmm, having required fields is a great thing to have. Days checkboxes I added to keep track of when you last solved the problem. According to concept of spaced repetition one should keep revising after some interval of time, that's why I added the checkboxes. Also, thank you for the template, let's think what we can add of that.

Thank you for the suggestion, do you want to work with me on this? You can fork, create issues and send me PRs if you feel like adding any new features to this. This way we both can work together.

JuanGuerrero09 commented 1 year ago

Hi, yup, I'm still learning, so I'll need to check how to fork and create the PR, but I'm on board. I wanted to ask you three things first, I saw that you used CRA when you created the project, I've used Vite since a few months and I find it really faster than CRA (since Vite is faster than Webpack), can I try to migrate it for development? Second, about the Modal (and in general) is fine if I use a component library for it? (like react bootsrap) Third, since more than one person is going to work in the project, have you considered typescript?

nikhilkarve commented 1 year ago

Great to have you on board.

  1. If you can migrate without breaking, it's great. I don't know much about vite, I will look into it. You can migrate if you feel necessary. Though, when you do please create a documentation regarding migration.
  2. Not sure which modal you are talking about? The form to submit question? Sure. Another idea, we can put overlay when the form is open so that use will have to close the form if user wants to interact with other components of the app.
  3. We can move to typescript, better I was thinking of moving to SolidJS, but too much has already been written so I am just lazy to rewrite the whole thing.

P.S - Before you start working on any feature, open a new issue, write about it and start working on it by creating a feature-branch. This way we can keep track of different parts of code, features and can easily move back and forth. For every new feature, I suggest we create a different branch and not touch main branch. Looking forward to working in a team!