nikhilkumarrathi / cryptotrader-telegram

A Telegram bot written in Python which provides various Cryptocurrency Trading features, and Technical Analysis using Binance API.
MIT License
51 stars 19 forks source link

Suggest to loosen the dependency on schedule #6

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Hi, your project cryptotrader-telegram(commit id: 870f6acd9022de347b76cedc8cc6646cf3934314) requires "schedule==0.6.0" in its dependency. After analyzing the source code, we found that the following versions of schedule can also be suitable, i.e., schedule 0.4.3, 0.5.0, since all functions that you directly (3 APIs: schedule.init.clear, schedule.init.every, schedule.init.run_pending) or indirectly (propagate to 4 schedule's internal APIs and 0 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on schedule from "schedule==0.6.0" to "schedule>=0.4.3,<=0.6.0". This will improve the applicability of cryptotrader-telegram and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on schedule?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?