search

nikhilm / node-taglib

Simple taglib bindings to Javascript using node.js
http://nikhilm.github.com/node-taglib
MIT License
147 stars 25 forks source link

Fix compilation bug (Loop()) #20

Closed lennart closed 12 years ago

lennart commented 12 years ago

Use uv_default_loop() in tag.cc instead of the (undeclared?) Loop().

In case this isn't what you wanted, or you have some uncommitted code in your working copy, please regard this pull request as obsolete!

nikhilm commented 12 years ago

Thanks for this, but I already have an uncommitted fix :) I'm wrestling with the async code (some weird bug) so I've been forgetting to commit.

Loop() was introduced when isolates were added, but has been reverted, hence the break

lennart commented 12 years ago

ok, I commented on your ASync API issue and just started hacking in async write support. We could be opening an IRC channel since these issue conversations aren't the right spot I think. Maybe I am already reimplementing something you have already done.

nikhilm commented 12 years ago

I'm nsm on Freenode

On Fri, Feb 24, 2012 at 3:56 PM, Lennart Melzer reply@reply.github.com wrote:

ok, I commented on your ASync API issue and just started hacking in async write support. We could be opening an IRC channel since these issue conversations aren't the right spot I think. Maybe I am already reimplementing something you have already done.

Reply to this email directly or view it on GitHub: https://github.com/nikhilm/node-taglib/pull/20#issuecomment-4154725

lennart commented 12 years ago

Ok, I'll try to reach you there… I am lcm

nikhilm commented 12 years ago

i've sent you an email on me@lmaa.name. is that your current email address?