search

nikhilm / node-taglib

Simple taglib bindings to Javascript using node.js
http://nikhilm.github.com/node-taglib
MIT License
147 stars 25 forks source link

Node 0.10.x compatibility #39

Closed masterkain closed 11 years ago

masterkain commented 11 years ago

Hello, this pull request tries to address node 0.10 compatibility.

There are still few warnings though, I'm unsure how to proceed.

../src/taglib.h:22:22: warning: unused function 'createFile' [-Wunused-function]
static TagLib::File *createFile(TagLib::IOStream *stream, TagLib::String format);

../src/tag.cc:17:20: warning: unused function 'now' [-Wunused-function]
static suseconds_t now()

../src/taglib.cc:296:1: warning: control reaches end of non-void function [-Wreturn-type]
}
nikhilm commented 11 years ago

I'm sorry about the late reply. I'll look at this within a day.

masterkain commented 11 years ago

it should also be noted that a breakage with older versions will occur.

nikhilm commented 11 years ago

Thanks!

Merged with other warnings fixed in later commits. Minimum required version of node is now 0.10.0. Haven't cut a release yet.

nikhilm commented 11 years ago

I'm not sure why github didn't track the merge.