search

nikhilm / node-taglib

Simple taglib bindings to Javascript using node.js
http://nikhilm.github.com/node-taglib
MIT License
147 stars 25 forks source link

Error building with Node v0.10.15 and upstream taglib #42

Closed parshap closed 11 years ago

parshap commented 11 years ago

I get this output when trying to install taglib:

> taglib@0.7.0 install /home/parshap/projects/album-organizer/node_modules/taglib
> node-gyp rebuild

make: Entering directory `/home/parshap/projects/album-organizer/node_modules/taglib/build'
  CXX(target) Release/obj.target/taglib/src/bufferstream.o
../src/taglib.h:26:22: warning: ‘TagLib::File* node_taglib::createFile(TagLib::IOStream*, TagLib::String)’ declared ‘static’ but never defined [-Wunused-function]
  CXX(target) Release/obj.target/taglib/src/tag.o
../src/tag.cc: In static member function ‘static v8::Handle<v8::Value> node_taglib::Tag::SyncTag(const v8::Arguments&)’:
../src/tag.cc:163:49: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
../src/tag.cc:172:124: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
../src/tag.cc: In static member function ‘static v8::Handle<v8::Value> node_taglib::Tag::AsyncTag(const v8::Arguments&)’:
../src/tag.cc:228:98: error: invalid conversion from ‘void (*)(uv_work_t*) {aka void (*)(uv_work_s*)}’ to ‘uv_after_work_cb {aka void (*)(uv_work_s*, int)}’ [-fpermissive]
/home/parshap/.node-gyp/0.10.15/deps/uv/include/uv.h:1432:15: error:   initializing argument 4 of ‘int uv_queue_work(uv_loop_t*, uv_work_t*, uv_work_cb, uv_after_work_cb)’ [-fpermissive]
../src/tag.cc: In static member function ‘static v8::Handle<v8::Value> node_taglib::Tag::AsyncSaveTag(const v8::Arguments&)’:
../src/tag.cc:291:98: error: invalid conversion from ‘void (*)(uv_work_t*) {aka void (*)(uv_work_s*)}’ to ‘uv_after_work_cb {aka void (*)(uv_work_s*, int)}’ [-fpermissive]
/home/parshap/.node-gyp/0.10.15/deps/uv/include/uv.h:1432:15: error:   initializing argument 4 of ‘int uv_queue_work(uv_loop_t*, uv_work_t*, uv_work_cb, uv_after_work_cb)’ [-fpermissive]
../src/taglib.h: At global scope:
../src/taglib.h:26:22: warning: ‘TagLib::File* node_taglib::createFile(TagLib::IOStream*, TagLib::String)’ declared ‘static’ but never defined [-Wunused-function]
../src/tag.cc:17:20: warning: ‘suseconds_t node_taglib::now()’ defined but not used [-Wunused-function]
make: *** [Release/obj.target/taglib/src/tag.o] Error 1
make: Leaving directory `/home/parshap/projects/album-organizer/node_modules/taglib/build'

I am using Node v0.10.15 and taglib/taglib@89fcab5669013bd46b0ef7b7f6efbb8a21cd1ceb.

parshap commented 11 years ago

I learned from #40 that what is released to npm does not support Node v0.10.0 but master does. Installing node-taglib from git works.