Supporting node 0.11 using Nan

nikhilm / node-taglib

Simple taglib bindings to Javascript using node.js

http://nikhilm.github.com/node-taglib

MIT License

147 stars 25 forks source link

Open joebain opened 10 years ago

joebain commented 10 years ago

I have started working on a music app recently and wanted to use node 0.11 (I'm using Koa). So I've ported the bindings to use Nan.

Tests pass on node 0.10 and 0.11, on Ubuntu. I haven't tried on OSX or Windows.

I'm not sure if this would have been better based off another branch? Anyway, let me know and I can make any changes necessary.

halleysfifthinc commented 9 years ago

+1 any updates on this?

ffalt commented 9 years ago

thanks for the porting. until this gets merged, I'm using your version.

tests are passing with: OSX Yosemite 10.10.2 latest taglib from git node v0.12.2