Closed Rwwn closed 1 year ago
@Rwwn good to know that this provider is helpful for you.
The changes looks good too. I will test it once and merge it ASAP.
Thank you for this contribution @Rwwn
Thanks for merging it @nikhilsbhat. Will it be included in a release soon so I can start using it?
yes @Rwwn, I'm working on it. Fixing few more feedback that I received.
First off I'd like to thank you for creating this provider. The fact it lets me manage elastic agent configurations is invaluable. I've yet to see any other config as code tool allow that in GoCD. Please keep it up.
I've got three changes I'd like to suggest here:
x509: certificate signed by unknown authority
I'm seeing when trying to use the provider without a ca_cert field.I haven't tested these changes as I'm not sure on how I'd do that exactly.I've tested this by using a local version of the provider with my changes, and it's all working, at least with my configuration.This is my first time contributing to a Terraform provider. I'm happy to take any suggestions if you have them.