Code reviews for BusDbAdapterTest.java

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Copy the BusDbAdapterTest.java to the src folder of the android test project

Original issue reported on code.google.com by QUANGHUY...@gmail.com on 23 Feb 2010 at 8:20

Attachments:

• BusDbAdapterTest.java

[GoogleCodeExporter]

CODE REVIEW - Bus Stop Alarm
Date: Feb 24, 2010
File: BusDbAdapterTest.java (in modules folder)
Revision: 122
Author: Huy Dang
Reviewer: Derek Cheng

Summary:

This is a first review of BusDbAdapterTest.java. This file contains unit tests 
for 
the BusDbAdapter class, which was reviewed earlier. Author has added unit tests 
for 
testing update and delete methods in the BusDbAdapter class, starting from 
around 
line 200; they will be the focus of this review, although other pre-existing 
tests 
will be reviewed briefly as well. This review will focus primarily on code 
formatting, the use of comments, adherence to Java / Android style guidelines, 
and 
unit test guidelines as per The Art of Unit Testing.

Comments:

CODING STANDARDS
Follows guidelines on spacing, indents, naming conventions.

COMMENTS
There are comments on top of every test. Author and file description are 
present on 
top of file.

LOGIC
Tests independent of each other, correct assertion type used in each test, one 
assertion per test, seems to be following the guidelines.

ERROR HANDLING
N/A

CODE DECISIONS
There seems to be sufficient test coverage in terms of covering BusDbAdapter 
methods, 
including corner cases.

Status:

Great! Seems ready for check-in.

Original comment by chen...@gmail.com on 24 Feb 2010 at 8:58

[GoogleCodeExporter]

Original comment by chen...@gmail.com on 24 Feb 2010 at 8:58

• Changed state: Done

[GoogleCodeExporter]

Since we failed to set up the test project for current project and couldn't 
make it 
work for other after uploading to svn. We had to manually upload the file here 
so 
assigned person could do code review. After that, we figured what the problem 
is and 
test project is checked out successfully from svn
Issue updated:
What steps will reproduce the problem?
1. Check out the current newest version of BusDbAdapterTest.java based on the 
date 
this issue is created.
2. Code review requested for this file

Expected:
- all code should follow the coding style guideline
Actual:
- there're a few errors in coding style that will probably be pointed by code 
review

Original comment by QUANGHUY...@gmail.com on 14 Mar 2010 at 4:54