search

nikic / FastRoute

Fast request router for PHP
Other
5.13k stars 444 forks source link

Increase method visibility #212

Closed dlundgren closed 3 years ago

dlundgren commented 4 years ago

Allows classes that might extend DataGenerators to re-use the once private methods.

lcobucci commented 4 years ago

This is a no-go for me, but I'd like to hear from @nikic to see if we're aligned.

dlundgren commented 4 years ago

It'd be nice if abstract classes used protected instead of private properties/methods so that other developers who would like to experiment with features could more easily do so instead of resorting to using Reflection to access those methods or otherwise copying and pasting.

lcobucci commented 3 years ago

@dlundgren thanks for your contribution but I prefer not to merge this one.