nikita-rudenko / back-n-forth

VSCode extension that adds Go Back/Forward buttons ↔️
https://marketplace.visualstudio.com/items?itemName=nick-rudenko.back-n-forth
MIT License
17 stars 1 forks source link

Match icons on the Mac Touch Bar #1

Closed phatmann closed 4 years ago

phatmann commented 4 years ago

On the Mac, the back and forward icons on the Touch Bar are carets, not arrows. It would be less jarring if your toolbar icons matched. Thanks!

nasc-macbook-pro-vscode-touch-bar
nikita-rudenko commented 4 years ago

Sorry for the late reply. I use official VSCode icons. The design idea of VSCode doesn't imply to reflect different UI solutions (e.g. icons) on different OSs, all of the UI elements are the same on any system.

I'll close this issue. Thanks for your idea :slightly_smiling_face:

phatmann commented 4 years ago

I looked at the list of icons. There are no icons specifically for back or forward. So choosing the icons that are used In the Touch Bar makes some sense. In fact I would argue those icons were omitted from the list by mistake and I am going to file an issue about it with them.

phatmann commented 4 years ago

https://github.com/microsoft/vscode-icons/issues/10

phatmann commented 4 years ago

Per this response from MS to issue above, your extension should use chevron-right and chevron-left.

nikita-rudenko commented 4 years ago

You are right. There are no specific icons for back and forward actions in the repo and I chose arrows from the common group. I think most of the users expect to see arrows for this action. Here is how they look in Chrome on Linux:

Screenshot from 2019-10-10 23-09-46

And if we look at VSCode UI, chevrons are mostly used for panels but not navigation: Screenshot from 2019-10-10 23-44-23

Also, I see you. I'm not a Mac user but I know chevron-style icons are widely used for navigation in the Mac OS.

As a compromise, I would like to add an option to the settings so the user can choose either arrows or chevrons. What do you think?

phatmann commented 4 years ago

An option would be ideal!

nikita-rudenko commented 4 years ago

I just updated the extension 🙂

phatmann commented 4 years ago

Yes!!! It looks awesome. Thanks for this!

I have no idea why VS Code does not show back and forward in its toolbar. So glad you fixed this.