search

nikita-rudenko / back-n-forth

VSCode extension that adds Go Back/Forward buttons ↔️
https://marketplace.visualstudio.com/items?itemName=nick-rudenko.back-n-forth
MIT License
17 stars 1 forks source link

Update package.json to ensure extension can run in different extension host setups #16

Closed bamurtaugh closed 3 years ago

bamurtaugh commented 3 years ago

Hi! I'm from the VS Code team, and we'd like to ensure Back & Forth can run in the different extension host setups VS Code currently supports. I've found that the current definition of extensionKind for your extension is too restrictive.

The extension has the extensionKind set to ["ui"]: https://github.com/nikita-rudenko/back-n-forth/blob/master/package.json#L24. This defines that the extension can only run in the VS Code desktop extension host.

However, this extension can also run on the workspace extension host (which is used for remote scenarios) since it doesn't have any dependencies on the desktop extension host. It'd also be great to enable it for Codespaces web.

Thus, to ensure your extension can run properly across setups, we'd recommend to change the extensionKind to "extensionKind": ["ui", "workspace"]. More information about extensionKind can be found here.

Please let me know if you have questions - I'm happy to help clarify anything. Thank you!

bamurtaugh commented 3 years ago

Hey @nikita-rudenko - just wanted to check in to see if there is any additional info I might be able to provide to help with this, or if it would be more helpful for me to open a PR with the change. Thank you!

nikita-rudenko commented 3 years ago

Thanks for notifying me, @bamurtaugh! I just published the update.