Closed robx closed 2 years ago
should Windows be added to CI to verify this / prevent it in the future?
Sure! Let's do that.
Regarding the constructor conflict, I suggest to do one of the following:
Close
on the import of Hasql.Pool.Prelude
UsageError
type.Boolean
.I think, the second option is better, since it makes the codebase more consistent. Also the third option seems fine too.
I went with the Bool
option now for simplicity (naming things is hard), and gave up on Windows CI for now, filed the failed attempt over at #21.
Somehow, we import GHC.Event.Windows.ConsoleEvent.Close on Windows via Hasql.Pool.Prelude, which conflicts with Close.
See this PostgREST CI failure: https://pipelines.actions.githubusercontent.com/serviceHosts/996fe3a3-010d-4e7c-a003-8e967bc4327c/_apis/pipelines/1/runs/2550/signedlogcontent/2?urlExpires=2022-08-30T06%3A30%3A28.3317426Z&urlSigningMethod=HMACV1&urlSignature=hCE13v%2Fp7jkakftXs%2FRp%2FY1EkmZVfgiucJpcj1kcobA%3D