nikita-volkov / hasql-pool

A pool of connections for Hasql
http://hackage.haskell.org/package/hasql-pool
MIT License
17 stars 15 forks source link

Move to DiffTime for timeouts #34

Closed nikita-volkov closed 1 year ago

nikita-volkov commented 1 year ago

At the moment we specify timeouts in microseconds using Int. I see a few problems. The microsecond precision seems like a clear overkill and a usage overhead. Milliseconds or even seconds could be better. Another problem is that the Int type carries zero information about what precision we use. So I've given here a go for the DiffTime type.

@robx What's your opinion?

robx commented 1 year ago

Sounds good to me!