nikita-volkov / hasql-pool

A pool of connections for Hasql
http://hackage.haskell.org/package/hasql-pool
MIT License
17 stars 15 forks source link

allows for striped resource pools #4

Closed ekalosak closed 2 years ago

nikita-volkov commented 5 years ago

I could never imagine why one would need this, which is why I didn't include this option. Can you elaborate on why you need this functionality?

ekalosak commented 5 years ago

Just following the principle of least surprise with respect to an interface to Data.Pool - it might make sense to have a defaultSettings that disables striping for those not interested in it. Quoting from the Data.Pool docs, "More stripes will lead to reduced contention in high-performance multicore applications, at a trade-off of causing the maximum number of simultaneous resources in use to grow." It's a feature that's useful in high performance APIs.

nikita-volkov commented 2 years ago

Closing since the package has moved away from "resource-pool".