search

nikita-volkov / hasql-pool

A pool of connections for Hasql
http://hackage.haskell.org/package/hasql-pool
MIT License
17 stars 15 forks source link

Introduce flexible config #42

Closed nikita-volkov closed 6 months ago

nikita-volkov commented 6 months ago

The point of this is to simplify the interface of the initialization functions and avoid their flavourization (i.e., acquireDynamically) by delegating that to configuration. Another important aspect is to make it possible to add new settings to the configuration without the need to bump the major version, thus making the package more stable for the users.

Pinging active users for review. @robx, @steve-chavez, @avanov, @domenkozar.

domenkozar commented 6 months ago

Big :+1: from me

avanov commented 6 months ago

This is good, I like it!

nikita-volkov commented 6 months ago

Thanks for quick responses guys! I'll wait a couple of days, merge and release if no complaints arise.

nikita-volkov commented 6 months ago

Thanks for cooperation guys! It's released.