nikita-volkov / refined

Refinement types with static checking
http://hackage.haskell.org/package/refined
MIT License
182 stars 31 forks source link

Drop these #17

Closed treeowl closed 6 years ago

treeowl commented 6 years ago

The these package brings in a bunch of very heavy transitive dependencies (e.g., profunctors, QuickCheck, and aeson). Unfortunately, refined does expose the These type through RefinedException, so dropping the dependency would be a breaking change. Nevertheless, I think it would be better to write a local copy of These and use that instead. Users who want to convert to the official These type shouldn't have any serious difficulty doing so.

chessai commented 6 years ago

I meant to do this because I dislike using "These" for this very reason. Will do this tomorrow

On Thu, Jun 14, 2018, 8:01 PM David Feuer notifications@github.com wrote:

The these package brings in a bunch of very heavy transitive dependencies (e.g., profunctors, QuickCheck, and aeson). Unfortunately, refined does expose the These type through RefinedException, so dropping the dependency would be a breaking change. Nevertheless, I think it would be better to write a local copy of These and use that instead. Users who want to convert to the official These type shouldn't have any serious difficulty doing so.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nikita-volkov/refined/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyL61MHgmwkDNNid9zClO83w5WlrWFJks5t8vllgaJpZM4Uo1Oh .