search

nikita36078 / J2ME-Loader

A J2ME emulator for Android.
Apache License 2.0
1.72k stars 195 forks source link

Add a virtual menu button instead of ActionBar #232

Closed NextDayOne closed 2 years ago

NextDayOne commented 6 years ago

Hi, I think it would be better and simpler if ActionBar were to be replaced with a virtual menu button, as in My Boy! (GBA Emulator). I do not like to enable ActionBar because it takes up a certain amount of screen space and this bothers me a bit when I'm playing, even though my phone does not have the hardware menu button, so putting a virtual button to access the common settings would be better because it takes up less screen space.

AdityaMH commented 6 years ago

That like floating "action menu", right? But, that's more bothering when game is touchscreen.

The best solution is make option "action bar size" or make action bar more smaller.

Since action bar is full width, it be better if add screen orientation button. 😆

NextDayOne commented 6 years ago

That's right, adding a floating button to access common settings same as the My Boy! emulator 806010444_8212 screenshot_2018-03-20-10-00-31

nikita36078 commented 6 years ago

I'm thinking about using Immersive Mode, it seems to be pretty good solution.

NextDayOne commented 6 years ago

The Immersive Mode would also be great

nikita36078 commented 6 years ago

I added Immersive Mode and also you can open menu with back button now, so I guess ActionBar isn't needed anymore :)

NextDayOne commented 6 years ago

Yes, I noticed that, thank you. But when I press the back button, it also opens the notification bar, is this a mistake or is it supposed to be anyway? screenshot_2018-03-23-10-04-24

nikita36078 commented 6 years ago

It is how Android reacts to the menu opening, unfortunately.

NextDayOne commented 6 years ago

I still think you'd better to put a virtual button to access the settings than the action bar or pressing the Back button, now that you have added the immersive mode, on devices with virtual keys, it will be a bit harder for you to access the settings because the Back button will be hidden because of the immersive mode and also because Android partially opens the notification bar on some devices when you press the Back button.

AdityaMH commented 6 years ago

I think immersive mode not needed if ActionBar is enabled. And why not try moving the menu down a little bit to avoid clicked notification bar simultaneously?

nikita36078 commented 2 years ago

Added