nikita36078 / J2ME-Loader

A J2ME emulator for Android.
Apache License 2.0
1.72k stars 195 forks source link

Better File selector drawer #237

Open hex007 opened 6 years ago

hex007 commented 6 years ago

Hey @nikita36078 I have a working File selector like this. Would you be interested in incorporating this or changing the current one. The current one looks outdated and I think it needs a fresher look.

I was looking for a way to open source the module. I am okay with releasing it under Apache.

screenshot_20180323-012149

nikita36078 commented 6 years ago

Yes, it is a good idea. Yours seems to be interesting, however I need to look at another 3rd party filepickers, too :)

nikita36078 commented 6 years ago

Well, I ended up with https://github.com/spacecowboy/NoNonsense-FilePicker, because I already used it before and it is pretty flexible.

oatmeal01 commented 6 years ago

the new file browser is great, how about adding file size info and visible file name and extension(text wrap like the image below instead of "...") on the next update. Ss from zarchiver's filebrowser screenshot_2018-03-24-03-23-09

AdityaMH commented 6 years ago

And then, why java files with .JAR (not .jar) format not listed in file drawer?

oatmeal01 commented 6 years ago

@aditya all file types are excluded except .jar and .jad

AdityaMH commented 6 years ago

why not include .JAR (capitalized format) in file drawer? My games lot with .JAR format.

nikita36078 commented 6 years ago

@AdityaMH It was a bug, fixed now.

AdityaMH commented 6 years ago

And why not add searching file, sort file, and icon jar too?

oatmeal01 commented 4 years ago

@nikita36078 why does jad format can't be installed outside the app(you still need to browse for it through the filepicker). Unlike jar, you can install it through any third party file manager or easily install through browser after downloading. Can you implement jad installation outside the app.

woesss commented 4 years ago

@oatmeal01 https://github.com/nikita36078/J2ME-Loader/blob/8ac59481902a9184ba0e8e372012c0920a2c4064/app/src/main/AndroidManifest.xml#L58 - JAD and JAR are supported equally. Your system does not offer to choose in which application to open JAD? She open it in another application or reports that there are no applications to open? Can you write a system log when trying to open JAD (need log by tag 'ActivityManager')?

oatmeal01 commented 4 years ago

@oatmeal01

https://github.com/nikita36078/J2ME-Loader/blob/8ac59481902a9184ba0e8e372012c0920a2c4064/app/src/main/AndroidManifest.xml#L58

  • JAD and JAR are supported equally. Your system does not offer to choose in which application to open JAD? She open it in another application or reports that there are no applications to open? Can you write a system log when trying to open JAD (need log by tag 'ActivityManager')?

604